-
Notifications
You must be signed in to change notification settings - Fork 5.5k
chore: New Crowdin Translations by GitHub Action #38977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| }, | ||
| "alert": { | ||
| "message": "Warnhinweis" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Translation key removed while still in use
The alertAccountTypeUpgradeMessage translation key is being removed from 14 locale files (de, el, es, fr, hi, id, ja, ko, pt, ru, tl, tr, vi, zh_CN), but this key is still actively used in AccountTypeMessage.tsx and remains defined in the English source file. Users with these language settings will see missing translations or English fallback text when upgrading to a smart account.
Additional Locations (2)
395dc0d to
8f5b887
Compare
| }, | ||
| "alert": { | ||
| "message": "Warnhinweis" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Translations removed for active message key
The alertAccountTypeUpgradeMessage translation key is being removed from 14 locale files (de, el, es, fr, hi, id, ja, ko, pt, ru, tl, tr, vi, zh_CN), but this key is still actively used in AccountTypeMessage.tsx and present in the source English locale file. Users in affected locales will see English fallback text instead of their native language translations when viewing the account type upgrade alert.
Additional Locations (2)
8f5b887 to
036496a
Compare
| "message": "AirGap Vault" | ||
| }, | ||
| "alert": { | ||
| "message": "Warnhinweis" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Active translation key removed from multiple locale files
The alertAccountTypeUpgradeMessage translation key is being removed from 14 locale files (de, el, es, fr, hi, id, ja, ko, pt, ru, tl, tr, vi, zh_CN), but this key is actively used in AccountTypeMessage.tsx to display the smart account upgrade message. Users in these locales will see either the English fallback text or the raw key name instead of their translated content. The English source file still contains this key, suggesting this is an unintended Crowdin sync issue.
Additional Locations (2)
036496a to
222bab9
Compare
| "message": "AirGap Vault" | ||
| }, | ||
| "alert": { | ||
| "message": "Warnhinweis" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Translations removed for actively used translation key
The alertAccountTypeUpgradeMessage translation key is being removed from 14 locale files (de, el, es, fr, hi, id, ja, ko, pt, ru, tl, tr, vi, zh_CN), but this key is actively used in AccountTypeMessage.tsx. The English locales still contain this key. Users with these locales will see either English fallback text or potentially the raw key string instead of their localized message when viewing account upgrade alerts.
Additional Locations (2)
222bab9 to
260a9a5
Compare
| "alert": { | ||
| "message": "Warnhinweis" | ||
| }, | ||
| "alertAccountTypeUpgradeMessage": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Translations removed for actively used localization key
The alertAccountTypeUpgradeMessage translation key is being removed from 14 locale files, but the key is still defined in the English source locale and actively used in AccountTypeMessage.tsx. This will cause users with German, Greek, Spanish, French, Hindi, Indonesian, Japanese, Korean, Portuguese, Russian, Tagalog, Turkish, Vietnamese, and Chinese language settings to see English fallback text instead of their localized translation when encountering the smart account upgrade alert.
Additional Locations (2)
Builds ready [260a9a5]
UI Startup Metrics (1302 ± 106 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
260a9a5 to
461ed38
Compare
| "alert": { | ||
| "message": "Warnhinweis" | ||
| }, | ||
| "alertAccountTypeUpgradeMessage": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Translation key removed while still in use
The alertAccountTypeUpgradeMessage key is being removed from 14 non-English locales, but the key still exists in the English locale and is actively used in AccountTypeMessage.tsx. This will cause users with affected locales (German, Greek, Spanish, French, Hindi, Indonesian, Japanese, Korean, Portuguese, Russian, Tagalog, Turkish, Vietnamese, Chinese) to see the English fallback message instead of their localized translation when viewing the account type upgrade alert. This appears to be an unintended Crowdin sync issue.
Additional Locations (2)
461ed38 to
e69cdbc
Compare
Builds ready [e69cdbc]
UI Startup Metrics (1285 ± 100 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
e69cdbc to
0feb2f3
Compare
| "alert": { | ||
| "message": "Warnhinweis" | ||
| }, | ||
| "alertAccountTypeUpgradeMessage": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Translation key removed but still used in code
The alertAccountTypeUpgradeMessage translation key is being removed from 14 non-English locale files (de, el, es, fr, hi, id, ja, ko, pt, ru, tl, tr, vi, zh_CN), but the key still exists in app/_locales/en/messages.json and is actively used in AccountTypeMessage.tsx. This causes a translation regression where users with these locale settings will see the English fallback message instead of their localized translation when viewing the smart account upgrade alert.
Additional Locations (2)
0feb2f3 to
87db67f
Compare
87db67f to
188a1c7
Compare
Builds ready [ba89af0]
UI Startup Metrics (1264 ± 116 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ba89af0 to
212d67c
Compare
Builds ready [212d67c]
UI Startup Metrics (1271 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
212d67c to
4b3c54b
Compare
| "alert": { | ||
| "message": "Warnhinweis" | ||
| }, | ||
| "alertAccountTypeUpgradeMessage": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translations removed while key is still actively used
The alertAccountTypeUpgradeMessage translation key is being removed from 13 locale files (de, el, es, fr, hi, id, ja, ko, pt, ru, tl, tr, vi, zh_CN), but the key still exists in the English source file (en/messages.json) and is actively used in AccountTypeMessage.tsx. This causes non-English users to see English fallback text instead of their localized translations when the account type upgrade message is displayed.
Additional Locations (2)
Builds ready [4b3c54b]
UI Startup Metrics (1280 ± 108 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
4b3c54b to
427c8bf
Compare
Builds ready [427c8bf]
UI Startup Metrics (1251 ± 99 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
427c8bf to
ecf61e3
Compare
| "alert": { | ||
| "message": "Warnhinweis" | ||
| }, | ||
| "alertAccountTypeUpgradeMessage": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Active translation key removed while still in use
The alertAccountTypeUpgradeMessage translation key is being removed from 14 locale files, but this key is still actively used in AccountTypeMessage.tsx and remains defined in the English source locale. Users with these language settings (German, Greek, Spanish, French, Hindi, Indonesian, Japanese, Korean, Portuguese, Russian, Tagalog, Turkish, Vietnamese, Chinese) will now see English fallback text instead of their localized translation. This may be intentional Crowdin sync behavior, but warrants verification since it degrades the user experience for non-English speakers.
Additional Locations (2)
Builds ready [ecf61e3]
UI Startup Metrics (1277 ± 109 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ecf61e3 to
c86d88e
Compare
| "alert": { | ||
| "message": "Warnhinweis" | ||
| }, | ||
| "alertAccountTypeUpgradeMessage": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translations removed for actively used localization key
The alertAccountTypeUpgradeMessage translation key is being removed from 14 locales (de, el, es, fr, hi, id, ja, ko, pt, ru, tl, tr, vi, zh_CN), but the key is still actively used in AccountTypeMessage.tsx and exists in the English source locale. Users with these language settings will see English fallback text instead of localized content when upgrading to a smart account.
Additional Locations (2)
Builds ready [c86d88e]
UI Startup Metrics (1243 ± 107 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
c86d88e to
cd81039
Compare
Builds ready [cd81039]
UI Startup Metrics (1200 ± 114 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Note
Removes an obsolete translation key across localized message files.
alertAccountTypeUpgradeMessagefrommessages.jsonin all locales underapp/_locales/*/Written by Cursor Bugbot for commit cd81039. This will update automatically on new commits. Configure here.