Fix output ordering in new Scan API #1799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
commented
Dec 21, 2025
| # This helper eagerly skips the Scan if n_steps is known to be 1 | ||
| single_step_requested = False | ||
| if isinstance(n_steps, float | int): | ||
| if isinstance(n_steps, int | float): |
Member
Author
There was a problem hiding this comment.
reordered, just because ints are much more likely than float
ricardoV94
commented
Dec 21, 2025
| raise ValueError(error_msg) | ||
|
|
||
|
|
||
| def isNaN_or_Inf_or_None(x): |
Member
Author
There was a problem hiding this comment.
I think this is silly. If anybody disagrees let me know
Member
There was a problem hiding this comment.
Overriding a bad user input by guessing what he probably meant (by falling back to the sequence length and ignoring n_steps) was always an anti-pattern, so I like removing this.
jessegrabowski
approved these changes
Dec 21, 2025
ricardoV94
changed the title
Internally Scan places those outputs to the right of nit_sot. Helper function reordering to match user definition was not handling this correctly
ricardoV94
force-pushed
the
fix_scan_new_api_output_ordering
branch
from
46feb7f to
1d9d51e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1796