Revert accidental structured sparse changes #1800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Remove `structured_prefix` for Ops that map 0->0 *Do not introduce new structured ops that don't map 0->0 besides the ones that already existed
jessegrabowski
approved these changes
Dec 21, 2025
Member
jessegrabowski
left a comment
jessegrabowski
left a comment
There was a problem hiding this comment.
Approving because of the first half, but why also remove the new functions? It's a strict upgrade. I only implemented for functions that map 0->0
Member
Author
|
I was convinced I removed only those that don't respect that. May have made a mistake... |
Member
Author
import numpy as np
for op in ("exp2", "log2", "log10", "cos", "cosh", "arccos", "arccosh"):
assert getattr(np, op)(0.0) != 0, opDid I miss something? |
Member
|
No, I didn't check closely enough. Carry on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Remove
structured_prefixfor Ops that map 0->0*Do not introduce new structured ops that don't map 0->0 besides the ones that already existed
Closes #1795