-
-
Notifications
You must be signed in to change notification settings - Fork 522
Fix: Use x-api-key header for Claude API instead of Authorization: Bearer #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @dacsang97, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an authentication incompatibility issue with the Claude API when interacting with custom proxy endpoints. By aligning the API key header format with Anthropic's official specification, the change ensures reliable authentication across various deployment scenarios, improving the robustness of Claude API integrations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix an authentication issue with the Claude executor by changing the authentication header from Authorization: Bearer to x-api-key. This aligns with Anthropic's API documentation for static API keys.
While the change is correct for static API keys, I've identified a potential regression that could break authentication for users relying on OAuth access tokens. The executor can use both static keys and OAuth tokens, but the proposed change uses x-api-key for both. I've provided a critical-severity comment with a code suggestion to handle both authentication methods correctly by dynamically choosing the appropriate header based on the credential type.
Problem
The Claude executor was using
Authorization: Bearer <api-key>header format, which causes 401 authentication errors when using custom proxy endpoints that expect the standard Anthropicx-api-keyheader format.Root Cause
Anthropic's API documentation specifies using
x-api-keyheader for authentication, notAuthorization: Bearer. While the official Anthropic API may accept both formats, custom proxy endpoints often require the standardx-api-keyheader.https://platform.claude.com/docs/en/get-started
Solution
Modified
applyClaudeHeaders()function ininternal/runtime/executor/claude_executor.goto use:instead of:
Changes
Impact
Testing
Tested with: